another bug

d. · Post by d. » Wed Jul 02, 2008 11:11 am

I finally got enhancing /w wood to work for me (idk how, just logged in today and it worked).

I enhanced a bow with heartwood.

the bow had 32 mana leech prior.

the heartwood added 10 mana leech

the bow's ML property was overwritten, instead of now having 42 mana leech, it has 10 =p.

Archived topic from AOV, old topic ID:3202, old post ID:20379

Death · Post by **Death** » Wed Jul 02, 2008 11:59 am

d. wrote:I finally got enhancing /w wood to work for me (idk how, just logged in today and it worked).

I enhanced a bow with heartwood.

the bow had 32 mana leech prior.

the heartwood added 10 mana leech

the bow's ML property was overwritten, instead of now having 42 mana leech, it has 10 =p.

K, we'll fix that one up. It's overriding instead of tacking on.

Archived topic from AOV, old topic ID:3202, old post ID:20382

Red Squirrel · Post by **Red Squirrel** » Wed Jul 02, 2008 2:43 pm

Great another one of those that we fix but then comes back later. Starting to wonder if we're better off remaking craft system from scratch. It's a pure mess from the start. Whoever coded that part of RunUO was most likely on illegal drugs.

Archived topic from AOV, old topic ID:3202, old post ID:20386

Death · Post by **Death** » Wed Jul 02, 2008 2:57 pm

Red Squirrel wrote:Great another one of those that we fix but then comes back later. Starting to wonder if we're better off remaking craft system from scratch. It's a pure mess from the start. Whoever coded that part of RunUO was most likely on illegal drugs.

If we started remaking the craft system, I'd be tempted to fix OSI's blunders with messing it up during AOS.

Archived topic from AOV, old topic ID:3202, old post ID:20388

dprantl · Post by **dprantl** » Wed Jul 02, 2008 3:19 pm

Red Squirrel wrote:Great another one of those that we fix but then comes back later. Starting to wonder if we're better off remaking craft system from scratch. It's a pure mess from the start. Whoever coded that part of RunUO was most likely on illegal drugs.

Please give me an example of a part of RunUO that was not coded this way. Every time I look at some random piece of code, all I can do is

Archived topic from AOV, old topic ID:3202, old post ID:20390

Death · Post by **Death** » Wed Jul 02, 2008 3:38 pm

dprantl wrote: Please give me an example of a part of RunUO that was not coded this way. Every time I look at some random piece of code, all I can do is

This is true. I have asked myself numerous times "why?" when looking through some of their code. They seem to have a knack for hard coding everything. It's going to be a real bitch when they start implementing UOML because the things they've hard coded are now duplicated in several scripts.

In their defense, a few things were coded pretty nicely. I can't think of a certain case off the top of my head mind u.

Archived topic from AOV, old topic ID:3202, old post ID:20394

Red Squirrel · Post by **Red Squirrel** » Wed Jul 02, 2008 3:59 pm

dprantl wrote:
Red Squirrel wrote:Great another one of those that we fix but then comes back later. Starting to wonder if we're better off remaking craft system from scratch. It's a pure mess from the start. Whoever coded that part of RunUO was most likely on illegal drugs.
Please give me an example of a part of RunUO that was not coded this way. Every time I look at some random piece of code, all I can do is

Good point lol. I've rewritten so much major parts of RunUO and only barely started, I want to rewrite the way item properties work as well, its a true mess. There's no reason why weapons and armor and clothing need to be treated as separate types when it comes to properties. that should have been in the core in Item.cs.

Archived topic from AOV, old topic ID:3202, old post ID:20397