wood properties [fixed]

This is where you can make suggestions or report bugs that you've found
User avatar
Red Squirrel
Posts: 29209
Joined: Wed Dec 18, 2002 12:14 am
Location: Northern Ontario
Contact:

wood properties [fixed]

Post by Red Squirrel »

Randomly the wood properties stopped working, just a heads up, so if you craft anything you wont get the bonuses. I'm trying to figure out why code thats been working for months suddenly stopped working.

Archived topic from AOV, old topic ID:1725, old post ID:10985
Honk if you love Jesus, text if you want to meet Him!
User avatar
Death
Posts: 7919
Joined: Thu Sep 30, 2004 10:12 pm

wood properties [fixed]

Post by Death »

Red Squirrel wrote:Randomly the wood properties stopped working, just a heads up, so if you craft anything you wont get the bonuses. I'm trying to figure out why code thats been working for months suddenly stopped working.
I'll wager accidental overwrite.

Archived topic from AOV, old topic ID:1725, old post ID:10987
User avatar
Red Squirrel
Posts: 29209
Joined: Wed Dec 18, 2002 12:14 am
Location: Northern Ontario
Contact:

wood properties [fixed]

Post by Red Squirrel »

Nope the code is there and all.

What I noticed though is that the type is now returning the board instead of log, and the code checks against logs, and YewLog != YewBoard, so I swapped some stuff around and we'll see. If worse comes to worse I might have to check against both though, think I might of changed them at some point to add enhancement support.

I also decided I'll make arms lore work for all craft skills. I'll just have to tweak tailoring since imo leather armor has WAY too high of resists. That or I'll tweak blacksmithy so its higher, or at least the same as tailoring. Will be tricky to do without messing up artifacts though, so think I'll leave that one for later.

Archived topic from AOV, old topic ID:1725, old post ID:10989
Honk if you love Jesus, text if you want to meet Him!
User avatar
Death
Posts: 7919
Joined: Thu Sep 30, 2004 10:12 pm

wood properties [fixed]

Post by Death »

Red Squirrel wrote:Nope the code is there and all.

What I noticed though is that the type is now returning the board instead of log, and the code checks against logs, and YewLog != YewBoard, so I swapped some stuff around and we'll see. If worse comes to worse I might have to check against both though, think I might of changed them at some point to add enhancement support.

I also decided I'll make arms lore work for all craft skills. I'll just have to tweak tailoring since imo leather armor has WAY too high of resists. That or I'll tweak blacksmithy so its higher, or at least the same as tailoring. Will be tricky to do without messing up artifacts though, so think I'll leave that one for later.
Remember there's wood armor too which I will be working on when I get to carpentry.

Archived topic from AOV, old topic ID:1725, old post ID:10991
User avatar
Red Squirrel
Posts: 29209
Joined: Wed Dec 18, 2002 12:14 am
Location: Northern Ontario
Contact:

wood properties [fixed]

Post by Red Squirrel »

Yeah that works too now. I fixed the issue. Still have no clue why it changed since while we did play with craft system such as me doing the hue thing, i never touched the wood bonus part. :oops:

But craft system is a nightmare. Its almost as bad as looking at a calculus test.

Archived topic from AOV, old topic ID:1725, old post ID:10993
Honk if you love Jesus, text if you want to meet Him!
User avatar
Finlander
Posts: 619
Joined: Fri Feb 23, 2007 4:21 pm

wood properties [fixed]

Post by Finlander »

And who was right? :wink:


Dammit.... all the wasted bows and runic kit uses for nothing :evil:
Will there be any refund for those who actualy wasted their stuff for this...?

Archived topic from AOV, old topic ID:1725, old post ID:11011
Image┬hẸ ςhadoШlordς ╒ac┬ion
Vai missä se oli?
Nexus Graveheart
Posts: 487
Joined: Mon May 21, 2007 10:00 pm

wood properties [fixed]

Post by Nexus Graveheart »

I agree with Hector. I noticed that some bloodwood stuff I made didn't have any HPR and/or HLL.

Regardless, I still have my bad-ass stuff from when the runics were given as rewards. I was confused as to why this had changed.

Archived topic from AOV, old topic ID:1725, old post ID:11013
User avatar
Finlander
Posts: 619
Joined: Fri Feb 23, 2007 4:21 pm

wood properties [fixed]

Post by Finlander »

I think its still not working

Archived topic from AOV, old topic ID:1725, old post ID:11016
Image┬hẸ ςhadoШlordς ╒ac┬ion
Vai missä se oli?
User avatar
Red Squirrel
Posts: 29209
Joined: Wed Dec 18, 2002 12:14 am
Location: Northern Ontario
Contact:

wood properties [fixed]

Post by Red Squirrel »

The update still has to go through and theres been extensive changes to the crafts so we need to test those changes more before they go through. But think they'll make it for next SW.

Archived topic from AOV, old topic ID:1725, old post ID:11024
Honk if you love Jesus, text if you want to meet Him!
User avatar
Finlander
Posts: 619
Joined: Fri Feb 23, 2007 4:21 pm

wood properties [fixed]

Post by Finlander »

What about the refunding? personaly i just basicaly wasted like 25 charges of my bloodwood kit and some unenchanted bows which i enchanted and they ended up with nothing else than color change, ohh and yew runic fletching kit plus ofcourse the wood all them eated, bloodwood/yew/heartwood(enchanted couple bows with heartwood)

:evil:

Archived topic from AOV, old topic ID:1725, old post ID:11025
Image┬hẸ ςhadoШlordς ╒ac┬ion
Vai missä se oli?
User avatar
Red Squirrel
Posts: 29209
Joined: Wed Dec 18, 2002 12:14 am
Location: Northern Ontario
Contact:

wood properties [fixed]

Post by Red Squirrel »

The runic kit is a totally other system, I did not get around to testing that yet. In the initial tests the intensities were fine, but I'll have to recheck. could of just been a case of bad luck, like you can get with BRSKs.

Archived topic from AOV, old topic ID:1725, old post ID:11026
Honk if you love Jesus, text if you want to meet Him!
User avatar
Death
Posts: 7919
Joined: Thu Sep 30, 2004 10:12 pm

wood properties [fixed]

Post by Death »

Finlander wrote:And who was right? :wink:


Dammit.... all the wasted bows and runic kit uses for nothing :evil:
Will there be any refund for those who actualy wasted their stuff for this...?
That's out of my scope. That would require tracking items and verifying that the runic tool was not actually doing anything at the time (The problem existed on the wood bonuses and not on the runic tools).

I'm personally in favor of at least a partial reimbursement (Half charges on the same tool) provided the original item is tracked and verified.

Archived topic from AOV, old topic ID:1725, old post ID:11033
User avatar
Finlander
Posts: 619
Joined: Fri Feb 23, 2007 4:21 pm

wood properties [fixed]

Post by Finlander »

yes but when you use runic kit, shouldnt it add the wood bonuses PLUS the actual runic thing??

Cause it doesnt seem exactly right that you get as good runic bows with lets say ash kit as you get with bloodwood kit, now does it?

Archived topic from AOV, old topic ID:1725, old post ID:11041
Image┬hẸ ςhadoШlordς ╒ac┬ion
Vai missä se oli?
User avatar
Death
Posts: 7919
Joined: Thu Sep 30, 2004 10:12 pm

wood properties [fixed]

Post by Death »

Finlander wrote:yes but when you use runic kit, shouldnt it add the wood bonuses PLUS the actual runic thing??

Cause it doesnt seem exactly right that you get as good runic bows with lets say ash kit as you get with bloodwood kit, now does it?
Runic bonuses will stack with the wood bonuses as well as exceptional + arms lore bonus.

Runic kits increase the intensity of the property within a given range. They also increase the max amount of properties. It's like a bronze runic hammer vs a gold runic hammer. Gold has the potential to give you better stuff, but if you're unlucky, you can get crappier items than when you used the bronze. I remember making an executioner's axe with a bronze hammer that ended up being the one I kept after an unsuccessful crafting session with an agapite hammer.

I'll look over the runic percentages to make sure there's no error and see what red wants to do about the whole wood bonus thing.

Archived topic from AOV, old topic ID:1725, old post ID:11044
User avatar
Finlander
Posts: 619
Joined: Fri Feb 23, 2007 4:21 pm

wood properties [fixed]

Post by Finlander »

runic bonuses did not stack with the wood bonuses when i crafted, infact i got no wood bonuses at all. About arms lore i asked from squirrel and he said it has no effect to fletching, so iam now bit confused, does it? My own guess was that it does not.

But belive me, theres still somethign wrong with the crafting or was. get yourself bloodwood kit and make some bows and stuff, youll see what i mean.

Archived topic from AOV, old topic ID:1725, old post ID:11049
Image┬hẸ ςhadoШlordς ╒ac┬ion
Vai missä se oli?
User avatar
Death
Posts: 7919
Joined: Thu Sep 30, 2004 10:12 pm

wood properties [fixed]

Post by Death »

Finlander wrote:runic bonuses did not stack with the wood bonuses when i crafted, infact i got no wood bonuses at all. About arms lore i asked from squirrel and he said it has no effect to fletching, so iam now bit confused, does it? My own guess was that it does not.

But belive me, theres still somethign wrong with the crafting or was. get yourself bloodwood kit and make some bows and stuff, youll see what i mean.
That's right. Runic bonuses did not stack with the wood bonuses because the wood bonuses weren't working. That's fixed up but it will not be in effect on the live server until after server wars.

This fix should also apply arms lore to the bow weapons if memory serves me right (Don't quote me on that one). Red can explain all the crafting fixes/changes that were recently made but they aren't in until server wars.

You are right that there was something wrong with crafting: The wood bonuses were not taking effect when they should be. This has been fixed and should be in after server wars provided some other issue does not arrise.

Archived topic from AOV, old topic ID:1725, old post ID:11053
User avatar
Finlander
Posts: 619
Joined: Fri Feb 23, 2007 4:21 pm

wood properties [fixed]

Post by Finlander »

but doesnt that just mean that i indeed could have been making a better bow everytime i pressed 'okay' if things have had been normal? Cause wood effects would have bitten in, same with enchanting as wood efect didnt do anything in that either, not even 1% DI.

Archived topic from AOV, old topic ID:1725, old post ID:11056
Image┬hẸ ςhadoШlordς ╒ac┬ion
Vai missä se oli?
User avatar
Death
Posts: 7919
Joined: Thu Sep 30, 2004 10:12 pm

wood properties [fixed]

Post by Death »

Finlander wrote:but doesnt that just mean that i indeed could have been making a better bow everytime i pressed 'okay' if things have had been normal? Cause wood effects would have bitten in, same with enchanting as wood efect didnt do anything in that either, not even 1% DI.
You would have the bonuses from the wood you were using yes. If you crafted an exceptional bow, it would have the 35% dmi as well (Only if it was exceptional).

Archived topic from AOV, old topic ID:1725, old post ID:11065
User avatar
Red Squirrel
Posts: 29209
Joined: Wed Dec 18, 2002 12:14 am
Location: Northern Ontario
Contact:

wood properties [fixed]

Post by Red Squirrel »

The exceptional bonus would have worked, thats totally different code. Its one of the reasons I hate this system, some bonuses are actually based on other flags, they're not fully stored in aosproperties. If I was to redo it, I'd have to do a huge global, would be nasty, but I'd cut down on a couple thousand lines of code throughout all of RunUO. (its spread all over)

I'll be doing some further testing and hoping to get this update go through by SW. I unfortunately can't replace the runic kit since there is no way to actually track that it existed, or the items it made. My guess is that it was just a case of bad luck, since those extra bonuses aren't HUGE. The biggest one might be 16DI. And the runic counter would have to actually hit that property for it to stack, otherwise its just more low properties.

I'll look to ensure bloodwood runic is making half decent stuff though, maybe it needs to be upped a bit.

Archived topic from AOV, old topic ID:1725, old post ID:11072
Honk if you love Jesus, text if you want to meet Him!
User avatar
Finlander
Posts: 619
Joined: Fri Feb 23, 2007 4:21 pm

wood properties [fixed]

Post by Finlander »

but you know, i was wise, i still got the 2 kits i left other with one use, the bloodwood iam not sure how many it has left, but atleast i can show them bows i made with it, which got runic properties but no wood effect whatsoever, even execptionals.

Plus they might also be on test shard

Archived topic from AOV, old topic ID:1725, old post ID:11073
Image┬hẸ ςhadoШlordς ╒ac┬ion
Vai missä se oli?
User avatar
Death
Posts: 7919
Joined: Thu Sep 30, 2004 10:12 pm

wood properties [fixed]

Post by Death »

Finlander wrote:but you know, i was wise, i still got the 2 kits i left other with one use, the bloodwood iam not sure how many it has left, but atleast i can show them bows i made with it, which got runic properties but no wood effect whatsoever, even execptionals.

Plus they might also be on test shard
We'll take a look at what you have and see what we can do.

Archived topic from AOV, old topic ID:1725, old post ID:11075
User avatar
Finlander
Posts: 619
Joined: Fri Feb 23, 2007 4:21 pm

wood properties [fixed]

Post by Finlander »

so, could you check the refunding thing please?

Archived topic from AOV, old topic ID:1725, old post ID:11669
Image┬hẸ ςhadoШlordς ╒ac┬ion
Vai missä se oli?
sliptongue69
Posts: 829
Joined: Sat Aug 18, 2007 7:46 pm

wood properties [fixed]

Post by sliptongue69 »

Dude. That's more work than staff aught to be putting into mistakes...just go hack at some more trees and get on with it...

Archived topic from AOV, old topic ID:1725, old post ID:11695
Stupid fucking idiot in red shirted ass...
User avatar
Finlander
Posts: 619
Joined: Fri Feb 23, 2007 4:21 pm

wood properties [fixed]

Post by Finlander »

Last time i hacked trees they werent dropping runic kits or good nonmade unenchanted bows. Could be wrong of course.

I just think that if something wasnt working at time when someone used items it took him quite a bit of time to get, he should get a proper refund.

Cause unlike osi which aims for taking your money, wasnt this shard supposed to be fun and fair?

This isnt a huge thing, but it still would be fair to do a refunding and you know it.

And by the way, iam just not talking about myself here.



Edit: Plus they already said they are gona take a look at it, i was just merely asking if they forgot this or so.

Archived topic from AOV, old topic ID:1725, old post ID:11706
Image┬hẸ ςhadoШlordς ╒ac┬ion
Vai missä se oli?
sliptongue69
Posts: 829
Joined: Sat Aug 18, 2007 7:46 pm

wood properties [fixed]

Post by sliptongue69 »

I'm sure they've got more important things to do than refunds on something you shouldn't have wasted so much material on. If it wasn't a big thing to you, then let it go and move on.

Archived topic from AOV, old topic ID:1725, old post ID:11707
Stupid fucking idiot in red shirted ass...
Locked